Skip to content

Conversation

ppkarwasz
Copy link
Contributor

Due to a minor bug in JUnit 5.11.2 (junit-team/junit-framework#4054), fields meta-annotated with multiple @ExtendWith annotations are no longer recognized. We combine those annotations into single @ExtendWith annotations, which also looks better.

Closes #2843.

Edit: No changelog is necessary, since improvements to our test runtime are not advertised. One day we need to find a way to thank the suppliers of our test runtime.

Due to a minor bug in JUnit 5.11.x (junit-team/junit-framework#4054), fields meta-annotated with multiple `@ExtendWith` annotations are no longer recognized.
We combine those annotations into single `@ExtendWith` annotations, which also looks better.

Closes #2843.
@ppkarwasz ppkarwasz added the tests Pull requests or issues related to tests label Oct 7, 2024
@ppkarwasz ppkarwasz self-assigned this Oct 8, 2024
@vy vy added this to the 2.25.0 milestone Oct 9, 2024
@ppkarwasz ppkarwasz merged commit 2d61fe0 into 2.x Oct 10, 2024
9 checks passed
@ppkarwasz ppkarwasz deleted the feature/2.x/2843_junit_5_11 branch October 10, 2024 08:12
ppkarwasz added a commit that referenced this pull request Oct 16, 2024
This port #3069 to `main`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests or issues related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade JUnit to 5.11.0

2 participants